Handle Exception.ToString failures in text formatter#2197
Merged
nblumhardt merged 3 commits intoserilog:devfrom Sep 4, 2025
Merged
Handle Exception.ToString failures in text formatter#2197nblumhardt merged 3 commits intoserilog:devfrom
nblumhardt merged 3 commits intoserilog:devfrom
Conversation
Wraps Exception.ToString in a try-catch block to prevent logging failures if the method throws. If an error occurs, a fallback message with details is written instead.
nblumhardt
reviewed
Sep 3, 2025
Member
nblumhardt
left a comment
There was a problem hiding this comment.
Thanks for the PR! Couple of minor comments.
Member
|
Fantastic, thanks! I've just dug in, and |
Member
|
Thanks, Kris 👍 |
Merged
This was referenced Feb 10, 2026
This was referenced Mar 29, 2026
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2165.
Wraps Exception.ToString in a try-catch block to prevent logging failures if the method throws. If an error occurs, a fallback message with details is written instead.