[UploadController] Response now includes a raw_url field#533
Merged
sergix44 merged 1 commit intosergix44:masterfrom May 31, 2023
Merged
[UploadController] Response now includes a raw_url field#533sergix44 merged 1 commit intosergix44:masterfrom
raw_url field#533sergix44 merged 1 commit intosergix44:masterfrom
Conversation
|
I tested this out on an instance I'm running and it does indeed fix my issue at #493. The only thing I had to do is change my ShareX config to read the Closes #493 |
sergix44
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have sharex configured to add
/rawto the end of every uploaded file automatically but that results in broken.gifthumbnails in discord and requires extra configuration steps.This change just includes a properly formatted
raw_urlfield in the/uploadresponse that can be used more easily from sharex and creates working gif thumbnails in discord.Note: The broken gif thumbnails in discord seems to be entirely discords fault. I think they're just looking at the URL and seeing if it ends in
.gifwhich is why this change fixes that behavior.