Skip to content

Conversation

@sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #9041

@sushantdhiman sushantdhiman force-pushed the create-table-unique-keys branch from f86b7b3 to 805f5ae Compare September 21, 2018 17:11
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #9946 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9946      +/-   ##
==========================================
+ Coverage   96.09%   96.09%   +<.01%     
==========================================
  Files          63       63              
  Lines        9398     9402       +4     
==========================================
+ Hits         9031     9035       +4     
  Misses        367      367
Impacted Files Coverage Δ
lib/query-interface.js 91.11% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9ec57...ef5cbb6. Read the comment docs.

@sushantdhiman sushantdhiman force-pushed the create-table-unique-keys branch from 805f5ae to ef5cbb6 Compare September 21, 2018 17:16
@sushantdhiman sushantdhiman merged commit 057e535 into master Sep 21, 2018
@sushantdhiman sushantdhiman deleted the create-table-unique-keys branch September 21, 2018 17:28
@SimonSchick
Copy link
Contributor

Was this not backported to v4?

@sushantdhiman
Copy link
Contributor Author

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

queryInterface.createTable: "uniqueKeys" option does not work anymore

3 participants