Skip to content

Conversation

@sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #9504

@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #9896 into master will increase coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 0db96d3 into master Sep 8, 2018
@sushantdhiman sushantdhiman deleted the mssql-describe-table-nvarchar-len branch September 8, 2018 13:14
@UziTech
Copy link
Contributor

UziTech commented Apr 17, 2019

VARCHAR(max) returns a length of -1. Is that what it is supposed to be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants