Skip to content

Conversation

@papandreou
Copy link
Contributor

@papandreou papandreou commented Sep 7, 2018

Cherry-pick of 27e4494 with some trivial require conflicts sorted out.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Backport of #9879 to v4. I'm abusing CI to run the tests, as I don't have a working sequelize test setup locally.

@sushantdhiman
Copy link
Contributor

This is a breaking change because error type returned in case of acquire timeout is changed, can't be backported

@papandreou
Copy link
Contributor Author

I don't mind too much as we need to run a fork anyway, but that sounds like an overly strict interpretation of semver. I wouldn't consider a different error class being thrown as enough of a breaking change to delay an important fix to the next major release.

@sushantdhiman
Copy link
Contributor

This is an important fix but returning different Error class entirely for some condition is definitely a breaking change. User could be catching old TimeoutError and retrying transactions.

There is still a way to make this change non breaking, you can just include transaction.js changes which prevent rollback in case of no connection. I'll happily merge that change :)

@codecov
Copy link

codecov bot commented Sep 9, 2018

Codecov Report

Merging #9889 into v4 will increase coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit e26f62f into sequelize:v4 Sep 12, 2018
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 4.38.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants