fix(hasMany): don't propagate group to separated queries #9754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(rows[0].tasks[0].jobs.length).to.equal(2); | ||
| expect(rows[0].tasks[0].jobs[0].title).to.equal('Job #1'); | ||
| }) | ||
| // if we get here, this will fail (as it should) |
Contributor
There was a problem hiding this comment.
no need for catch / expect, if there is any error it will throw when returned promise chain rejects
added 2 commits
August 2, 2018 10:49
Tests pass on my machine - however, it failed on Travis on account of weird sorting. Removed check - we don't really care which comes first.
sushantdhiman
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fixes issue #9748