Skip to content

Conversation

@sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #9476
Closes #9478

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #9672 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit a1bf40d into master Jul 17, 2018
@sushantdhiman sushantdhiman deleted the fix-9476 branch July 17, 2018 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants