Skip to content

fix(model): ignore VIRTUAL/getters with attributes.exclude #9568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sushantdhiman merged 4 commits into from
Jun 20, 2018
Merged

fix(model): ignore VIRTUAL/getters with attributes.exclude #9568

sushantdhiman merged 4 commits into from
Jun 20, 2018

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jun 20, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #5566
Fixes #5948

@sushantdhiman sushantdhiman requested a review from a team June 20, 2018 05:51
@codecov
Copy link

codecov bot commented Jun 20, 2018 •
edited
Loading

Codecov Report

Merging #9568 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 2c50b7e into master Jun 20, 2018
@sushantdhiman sushantdhiman deleted the fix-5566 branch June 20, 2018 17:37
@pi-kei pi-kei mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@janmeier janmeier janmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sushantdhiman @janmeier