Fix 9515: sync() with "alter:true" doesn't use field name in model definition #9529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add integration test
…mn name, enhance the existing integration tests for add/remove column to verify that the custom column name is used
…vironment" This reverts commit 3782763. Remove unrelated documentation commit from current PR branch
lib/model.js
Outdated
| }); | ||
| _.each(columns, (columnDesc, columnName) => { | ||
| const currentAttributes = attributes[columnName]; | ||
| const currentAttributes = rawAttributes[columnName]; |
Contributor
There was a problem hiding this comment.
rename currentAttributes to currentAttribute
Contributor
sushantdhiman
left a comment
There was a problem hiding this comment.
LGTM, one minor change
|
Why is this problem not fixed in version 4.41.2? |
|
@sushantdhiman I upgraded the version to the version 5.0.0-beta.14 and still have this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9515