Skip to content

feat(mariadb): support indexHints on mariadb dialect #11573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sushantdhiman merged 1 commit into from
Oct 18, 2019
Merged

feat(mariadb): support indexHints on mariadb dialect #11573

sushantdhiman merged 1 commit into from
Oct 18, 2019

Conversation

@benjamin658
Copy link
Contributor

@benjamin658 benjamin658 commented Oct 18, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Supports indexHints option on the mariadb dialect.

#11570

@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #11573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11573   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          94       94           
  Lines        9184     9184           
=======================================
  Hits         8842     8842           
  Misses        342      342
Impacted Files Coverage Δ
lib/dialects/mariadb/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2949a63...9b24fb3. Read the comment docs.

@sushantdhiman sushantdhiman merged commit a34399f into sequelize:master Oct 18, 2019
@sushantdhiman sushantdhiman mentioned this pull request Oct 18, 2019
Closed
6 tasks
@sushantdhiman
Copy link
Contributor

sushantdhiman commented Oct 18, 2019

🎉 This PR is included in version 5.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sushantdhiman sushantdhiman mentioned this pull request Oct 25, 2019
Open
4 tasks
This was referenced Oct 26, 2019
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
This was referenced Feb 3, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 1, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benjamin658 @sushantdhiman