Where in the error message would this newline be, when are newlines contained in error messages, please provide more info, this seems like a larger issue.

Where in the error message would this newline be, when are newlines contained in error messages, please provide more info, this seems like a larger issue.

with using mysql，this may case the error:
user.create({ name: 'john\r' }); user.create({ name: 'john\r' });
(if name is unique)
the error code is 1062，and the match() just return null.

In this case your fix is not sufficient.
There are many occurrences where err.message is matched via regex and .replace(string, string) only replaces a single occurrences, my suggestion is you add a util method called removeNewlines(str) { return str.replace(/[\r\n]/g, ''); and apply it to all of them.

In this case your fix is not sufficient.
There are many occurrences where err.message is matched via regex and .replace(string, string) only replaces a single occurrences, my suggestion is you add a util method called removeNewlines(str) { return str.replace(/[\r\n]/g, ''); and apply it to all of them.

do you think that is a good idea to change
(.*)
to
([\s\S]*)
when match err.message?

That could work too, depending on @sushantdhiman stance on v5 node version we could also use the /s flag (dotall) if we were to target v10.

Hehe, at this point I just want to release v5 asap. Please just use simple Node 6 constructs for now

Codecov Report

Merging #10320 into master will decrease coverage by 0.85%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10320      +/-   ##
==========================================
- Coverage   96.28%   95.42%   -0.86%     
==========================================
  Files          68       65       -3     
  Lines        9775     9556     -219     
==========================================
- Hits         9412     9119     -293     
- Misses        363      437      +74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0255e...78000e7. Read the comment docs.

Some tests randomly fail due to timing issues, you can ignore these.

v5 really is the way to go!

Looks this PR broke some MariaDB stuff https://travis-ci.org/sequelize/sequelize/jobs/481222290