fix(instance-validator): don't skip custom validators on null (#9143) #10310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Migration instructions available on upgrade-to-v5.md
test/unit/model/validation.test.js
Outdated
|
|
||
| describe('with allowNull set to true', () => { | ||
|
|
||
| const User = current.define('user', { |
Contributor
There was a problem hiding this comment.
Move this to before, use as this.User in assertions
Contributor
There was a problem hiding this comment.
Same goes for other tests
Contributor
sushantdhiman
left a comment
There was a problem hiding this comment.
Implementation looks good and good work with docs, just some minor changes to tests and this can be merged
Codecov Report
@@ Coverage Diff @@
## master #10310 +/- ##
==========================================
+ Coverage 96.28% 96.28% +<.01%
==========================================
Files 68 68
Lines 9772 9775 +3
==========================================
+ Hits 9409 9412 +3
Misses 363 363
Continue to review full report at Codecov.
|
Member
Author
|
@sushantdhiman Thanks for the review, I refactored it and also fixed a missing link in the docs. |
Contributor
|
Thanks @papb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fixes #9143. See this comment where the changes created by this PR are explained.
This is technically a breaking change but I believe the amount of affected people will be minimal. Regardless, migration instructions were added to docs/upgrade-to-v5.md and the documentation was properly updated, of course. Also, I since v5 is in beta, I think a minor breaking change is fine at the moment 😁