Skip to content

chore: cleanup #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sushantdhiman merged 1 commit into from
Dec 18, 2018
Merged

chore: cleanup #10276

sushantdhiman merged 1 commit into from
Dec 18, 2018

Conversation

@SimonSchick
Copy link
Contributor

@SimonSchick SimonSchick commented Dec 17, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #10275 I think

This is another small scale cleanup PR.

  • Replace some loops with Object.assign
  • Replace all usage of spread with native array spread
  • Use object literals in various places
  • Avoid aliasing of this

@codecov
Copy link

codecov bot commented Dec 18, 2018 •
edited
Loading

Codecov Report

Merging #10276 into master will decrease coverage by <.01%.
The diff coverage is 98.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10276      +/-   ##
==========================================
- Coverage   96.28%   96.27%   -0.01%     
==========================================
  Files          68       68              
  Lines        9797     9772      -25     
==========================================
- Hits         9433     9408      -25     
  Misses        364      364
Impacted Files Coverage Δ
lib/sequelize.js 96.36% <ø> (ø) ⬆️
lib/model.js 96.77% <100%> (-0.01%) ⬇️
lib/dialects/mysql/connection-manager.js 96.36% <100%> (-0.19%) ⬇️
lib/associations/has-one.js 97.24% <100%> (ø) ⬆️
lib/dialects/mssql/connection-manager.js 88.46% <100%> (-0.15%) ⬇️
lib/dialects/abstract/query-generator.js 97.63% <100%> (-0.01%) ⬇️
lib/associations/has-many.js 97.64% <100%> (-0.07%) ⬇️
lib/associations/belongs-to-many.js 97.61% <96.96%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a4533...c3dc4d5. Read the comment docs.

sushantdhiman
sushantdhiman reviewed Dec 18, 2018
View reviewed changes
lib/associations/belongs-to-many.js
[foreignIdentifier]: newObj.get(targetKey)
}
}
))
Copy link
Contributor

@sushantdhiman sushantdhiman Dec 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd indentation

@sushantdhiman sushantdhiman merged commit 891de8e into sequelize:master Dec 18, 2018
@sushantdhiman
Copy link
Contributor

sushantdhiman commented Dec 18, 2018

Thanks @SimonSchick 👍

@SimonSchick SimonSchick deleted the chore/cleanup branch December 18, 2018 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sushantdhiman sushantdhiman sushantdhiman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonSchick @sushantdhiman