docs: typo in associations.md #10157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like last example should define `association` rather then `model` in this case.
Using `model` the error happens:
```bash
Error: Unable to connect to the database TypeError: self._expandAttributes is not a function
at Function._conformOptions (<...>/node_modules/sequelize/lib/model.js:198:12)
at Function._conformInclude (<...>/node_modules/sequelize/lib/model.js:264:12)
at options.include.options.include.map.include (<...>/node_modules/sequelize/lib/model.js:213:59)
at Array.map (<anonymous>)
at Function._conformOptions (<...>/node_modules/sequelize/lib/model.js:213:39)
at new Model (<...>/node_modules/sequelize/lib/model.js:3070:24)
at new jp_kanji (<...>/node_modules/sequelize/lib/sequelize.js:340:19)
at Function.build (<...>/node_modules/sequelize/lib/model.js:1966:12)
at Function.create (<...>/node_modules/sequelize/lib/model.js:2017:17)
<client code>
```
Codecov Report
@@ Coverage Diff @@
## master #10157 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 63 63
Lines 9426 9426
=======================================
Hits 9082 9082
Misses 344 344Continue to review full report at Codecov.
|
Contributor
|
Thanks @ggarek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Maybe this checklist does not apply to the change.
Description of change
Probably, wrong property was being used in the docs example. This PR fixes this typo.
Looks like the last example should define
associationrather thenmodelin this case.Using
modelthe error happens:Error: Unable to connect to the database TypeError: self._expandAttributes is not a function at Function._conformOptions (<...>/node_modules/sequelize/lib/model.js:198:12) at Function._conformInclude (<...>/node_modules/sequelize/lib/model.js:264:12) at options.include.options.include.map.include (<...>/node_modules/sequelize/lib/model.js:213:59) at Array.map (<anonymous>) at Function._conformOptions (<...>/node_modules/sequelize/lib/model.js:213:39) at new Model (<...>/node_modules/sequelize/lib/model.js:3070:24) at new jp_kanji (<...>/node_modules/sequelize/lib/sequelize.js:340:19) at Function.build (<...>/node_modules/sequelize/lib/model.js:1966:12) at Function.create (<...>/node_modules/sequelize/lib/model.js:2017:17) <client code>