refactor: reduce code complexity #10120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10120 +/- ##
==========================================
+ Coverage 96.33% 96.35% +0.01%
==========================================
Files 63 63
Lines 9431 9426 -5
==========================================
- Hits 9085 9082 -3
+ Misses 346 344 -2
Continue to review full report at Codecov.
|
e2e0741 to
4769e12
Compare
Contributor
Author
|
Hey @sushantdhiman you think we can get my last 2 PRs in before v5 goes live? :) |
Contributor
sushantdhiman
left a comment
There was a problem hiding this comment.
Some changes otherwise LGTM
4769e12 to
76231aa
Compare
Contributor
Author
|
done |
Contributor
|
Thanks @SimonSchick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
else (if)'s with linter help..npmignorewithfilesinpackage.jsonand exclude all redundant files for use.On another note, is there a reason you call
Error.captureStackTrace(this, this.constructor);on all error errors?Are you doing to to prevent it from capturing the first stack frame?
This will be my last code cleanup PR until v5 is out.