fix(query-generator): fix add comment when addColumn on postgres(#4386) #10076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10076 +/- ##
==========================================
+ Coverage 96.3% 96.3% +<.01%
==========================================
Files 63 63
Lines 9413 9417 +4
==========================================
+ Hits 9065 9069 +4
Misses 348 348
Continue to review full report at Codecov.
|
5 tasks
Contributor
|
@theRichu This needs unit tests from remaining two dialects i.e mysql and mssql |
Contributor
|
@theRichu let me know if you don't have time to fix this and I can take a look. |
Author
|
@mirkojotic thanks!! |
5 tasks
Contributor
|
@sushantdhiman if @theRichu doesn't mind we can close this PR in favour of |
Contributor
|
Fixed by #10117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
#4386
Error comment on addColumn