Skip to content

fix: throw on undefined where parameters #10048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sushantdhiman merged 1 commit into from
Oct 20, 2018
Merged

fix: throw on undefined where parameters #10048

sushantdhiman merged 1 commit into from
Oct 20, 2018

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 20, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Follow up from #9548, Now Sequelize will throw for any undefined where keys

@codecov
Copy link

codecov bot commented Oct 20, 2018 •
edited
Loading

Codecov Report

Merging #10048 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10048      +/-   ##
==========================================
- Coverage    96.3%    96.3%   -0.01%     
==========================================
  Files          63       63              
  Lines        9418     9414       -4     
==========================================
- Hits         9070     9066       -4     
  Misses        348      348
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.65% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f758839...be160e1. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 7fd6d73 into master Oct 20, 2018
@sushantdhiman sushantdhiman deleted the fail-fast-on-undefined-where branch October 20, 2018 05:01
@sushantdhiman sushantdhiman mentioned this pull request Oct 20, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sushantdhiman