refactor(query-generation): cleanup template usage #10047
Conversation
|
Hey @sushantdhiman I changed the sqlite path resolve logic and now things aren't exactly working correctly, at least not in a unix environment... any suggestions? |
ea3d68a to
37e5b92
Compare
| }); | ||
| const quotedTable = this.quoteTable(tableName); | ||
| return 'SELECT name FROM sys.default_constraints ' + | ||
| // REVIEW: Already quoted? |
There was a problem hiding this comment.
I guess it is safe to remove ' if table is already quoted
lib/sequelize.js
Outdated
| * | ||
| * @returns {Model} Imported model, returned from cache if was already imported | ||
| */ | ||
| import(path) { |
There was a problem hiding this comment.
call this importPath may be, path and path = require('path') are conflicting
There was a problem hiding this comment.
Something something type checking.
Codecov Report
@@ Coverage Diff @@
## master #10047 +/- ##
==========================================
- Coverage 96.3% 96.3% -0.01%
==========================================
Files 63 63
Lines 9414 9412 -2
==========================================
- Hits 9066 9064 -2
Misses 348 348
Continue to review full report at Codecov.
|
dd6fdee to
0771823
Compare
|
Everything seems to be in order now, the one failing test looks like a race-condition or transient failure. |
|
Thanks @SimonSchick |
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Waiting for integration tests to run in CI