feat(cli): warn that std libs are ignored if --include-std is not passed#97
feat(cli): warn that std libs are ignored if --include-std is not passed#97andrius-puksta-sensmetry merged 1 commit intomainfrom
--include-std is not passed#97Conversation
4f72f47 to
5819041
Compare
--include-std is not passed--include-std is not passed
5819041 to
5c68040
Compare
|
This looks good, but I think, at least for now, we need to always show some sort of warning when We have already had one issue opened #92 where the fact that the standard library did not get installed (even though it's a transitive dependency) led to confusion. The message can be much shorter in this case, and I would propose simply always printing it for any command that involves installing dependencies. Once this behaviour is either standardised or widely understood we can remove the message. |
This PR does always print the warning, except for the lock command. |
5c68040 to
5951a2f
Compare
says nothing about not installing stdlib dependencies, even though they are explicit dependencies of sysmod (this is precisely the case that confused the user in the ticket above). |
|
It does: (it shouldn't sync the env if packages didn't change, will fix that) |
When explicitly trying to install a standard library project yes, but not if that standard library project is only a (transitive) dependency, which will effectively be almost every project. |
|
Sorry, my bad. I meant to check with |
5951a2f to
b44d009
Compare
|
Fixed: Also shortened the warning messages and made them more specific. |
…assed also fix npm tests Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
b44d009 to
06ecda2
Compare
Closes #94.