Use enum for KerML checksum algorithms#128
Merged
andrius-puksta-sensmetry merged 16 commits intomainfrom Dec 8, 2025
Merged
Conversation
da36fde to
a23aa0f
Compare
9b6fdb6 to
fa31469
Compare
e1b238c to
d42bebd
Compare
d42bebd to
25f712a
Compare
Collaborator
vytautas-astrauskas-sensmetry
left a comment
There was a problem hiding this comment.
The metamodel stuff looks good for now. We can update it later in a separate PR after I discuss the design with the Reference Implementation working group.
ae6fba5 to
4866fae
Compare
adfce62 to
d28248f
Compare
21fcbbe to
64c1db7
Compare
Collaborator
victor-linroth-sensmetry
left a comment
There was a problem hiding this comment.
This is starting to feel finished, just merge/rebase main and make sure all tests still pass.
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
…ent `` quoting Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com> clarify comment about using `None` checksum algorithm Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
…ements Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
… log messages Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com> improve checksum hex validation Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
926d677 to
ec2da59
Compare
victor-linroth-sensmetry
approved these changes
Dec 8, 2025
Collaborator
victor-linroth-sensmetry
left a comment
There was a problem hiding this comment.
Okay, looks like everything is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
uses quoting in output
serializationinstead ofserialisationto match common usage other crates/ecosystems.project.jsonand.meta.json. Fixes Consider adding end-of-file newline when printing human readable JSON #112.CLI improvements
anstream. It's already used by default inenv_logger, so the only place where we used color unconditionally was insysand/src/main.rssysand info metamodel. Closes Simplify setting metamodel field #122. Current help output:sysand --helpby using a custom clap help template (based on default template):sysand info --help:Docs
Tests