Skip to content

feat: geolocation setter in sendgrid-ruby for GDPR compliance #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manisha1997 merged 18 commits into from
Nov 23, 2023
Merged

feat: geolocation setter in sendgrid-ruby for GDPR compliance #496

manisha1997 merged 18 commits into from
Nov 23, 2023

Conversation

@manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Nov 17, 2023 •
edited
Loading

feat!: Geolocation setter for sendgrid ruby
Ticket: DII-1232

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

tiwarishubham635
tiwarishubham635 reviewed Nov 17, 2023
View reviewed changes
Copy link

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrutiburman
shrutiburman reviewed Nov 21, 2023
View reviewed changes
shrutiburman
shrutiburman reviewed Nov 21, 2023
View reviewed changes
tiwarishubham635
tiwarishubham635 approved these changes Nov 23, 2023
View reviewed changes
Copy link

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manisha1997 manisha1997 merged commit 780e7a0 into main Nov 23, 2023
@manisha1997 manisha1997 deleted the 7.0.0-rc branch November 23, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shrutiburman shrutiburman shrutiburman left review comments

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manisha1997 @tiwarishubham635 @shrutiburman