Skip to content

Conversation

@grin
Copy link
Contributor

@grin grin commented May 11, 2021

Adds From address to personalization, as mentioned in: https://sendgrid.com/docs/for-developers/sending-email/personalizations/

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works there are no tests for personalizations
  • I have added the necessary documentation about the functionality in the appropriate .md file only added a doc comment in examples
  • I have added inline documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 11, 2021
@grin
Copy link
Contributor Author

grin commented May 11, 2021

This isn't triggering a travis build, any ideas why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants