Skip to content

fix: Accurate duplicate checking when adding email to Personalizations #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JenniferMah merged 2 commits into from
Jan 26, 2021
Merged

fix: Accurate duplicate checking when adding email to Personalizations #446

JenniferMah merged 2 commits into from
Jan 26, 2021

Conversation

@tmimura39
Copy link
Contributor

@tmimura39 tmimura39 commented Oct 31, 2020 •
edited
Loading

Fixes #445

Compare in downcase.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2020
@tmimura39 tmimura39 changed the title fix: Accurate duplicate checking when adding email to Personalizations fix!: Accurate duplicate checking when adding email to Personalizations Oct 31, 2020
@childish-sambino childish-sambino changed the title fix!: Accurate duplicate checking when adding email to Personalizations fix: Accurate duplicate checking when adding email to Personalizations Nov 2, 2020
@JenniferMah JenniferMah merged commit 37c0b75 into sendgrid:main Jan 26, 2021
@netwire88
Copy link

netwire88 commented Feb 24, 2021

Hi @mito5525 , I'm seeing additional bugs related to this release, not sure if it's on the roadmap to be fixed: #445 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@childish-sambino childish-sambino childish-sambino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicate checking when adding email to personalization is not accurate

5 participants

@tmimura39 @netwire88 @childish-sambino @thinkingserious @JenniferMah