Skip to content

feat: add mail_v3 functionality for reply_to_list #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbansla merged 1 commit into from
Aug 6, 2024
Merged

feat: add mail_v3 functionality for reply_to_list #471

sbansla merged 1 commit into from
Aug 6, 2024

Conversation

@lopezator
Copy link
Contributor

@lopezator lopezator commented Dec 19, 2023 •
edited
Loading

Add reply_to_list functionality. It just implements a feature that is available on api but not yet on the SDK (and should).

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@lopezator lopezator changed the title helpers: add mail_v3 functionality for reply_to_list feat: add mail_v3 functionality for reply_to_list Dec 19, 2023
@lopezator
feat: add mail_v3 functionality for reply_to_list
c76dfc3 
Add reply_to_list functionality.
@lopezator
Copy link
Contributor Author

lopezator commented Dec 19, 2023

Tested empirically sending email using my service and worked fine.

image

@sarinarw
Copy link

sarinarw commented Mar 28, 2024

bump - would like to have this feature added

sarinarw
sarinarw approved these changes Mar 28, 2024
View reviewed changes
Copy link

@sarinarw sarinarw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested this by importing it into my project and it successfully sent an email with multiple reply-tos

replace github.com/sendgrid/sendgrid-go => github.com/lopezator/sendgrid-go v0.0.0-20231219091217-c76dfc3e8156

Need someone with actual access to review - but LGTM FWIW

@sbansla sbansla self-requested a review August 2, 2024 10:15
@sbansla sbansla mentioned this pull request Aug 2, 2024
Closed
8 tasks
@sbansla sbansla merged commit e6d6376 into sendgrid:main Aug 6, 2024
zeisss
zeisss reviewed Sep 25, 2024
View reviewed changes
Copy link

@zeisss zeisss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry, please ignore.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbansla sbansla sbansla approved these changes

+2 more reviewers

@zeisss zeisss zeisss left review comments

@sarinarw sarinarw sarinarw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lopezator @sarinarw @zeisss @sbansla