Conversation
| a bug or introduce new functionality. I would usually expect additional code | ||
| for the latter instance, in which case it's obviously a minor level increment. | ||
|
|
||
| #### Special note for JVM or similar environments |
There was a problem hiding this comment.
The FAQ is currently part of the Semver spec itself, thus this should go in https://github.com/semver/semver/blob/master/semver.md. When the next version of Semver is finalized, it'll get copied over here and translated.
There was a problem hiding this comment.
There is a PR semver/semver#414 and a comment semver/semver#414 (review)
There was a problem hiding this comment.
@haacked There is an opposite opinion - semver/semver#414 (comment). Could you discuss with @jwdonahue ?
There was a problem hiding this comment.
@Primetalk, @haacked is the authority on this, my apologies for any confusion.
index.md
Outdated
|
|
||
| In such environments where only one version of a library could | ||
| be present in a running system, the transitive dependencies effectively become | ||
| part of the public library interface and thus the version of the user library SHOULD be |
There was a problem hiding this comment.
Why not reword section in order to use MUST (instead of SHOULD) ?
It would be better to clarify when you MUST do something. Instead of simply recommending with SHOULD.
Indeed, the potential effect is that libraries will still be semantic-versioning compliant even if they do not follow at all your recommendation!
I suggest to add something like "[...] If any potential client environment allows only one version of a library be present in running system, [...] user library MUST be [...]"
In linearized environments where all dependencies are resolved to just a single version, we MUST increment the version of the library to the same extent as transitive dependencies change.
index.md
Outdated
| #### Special note for JVM or similar environments | ||
|
|
||
| In such environments where only one version of a library could | ||
| I suggest to add something like "[...] If any potential client environment allows only one version of a library be present in running system, [...] user library MUST be [...]" |
There was a problem hiding this comment.
I guess line 229 (starting with "I suggest ...") was added in your last commit for mistake, it should be removed.
There was a problem hiding this comment.
Yeah, I'm sorry for the inconvenience.
|
Closing this until it's resolved on SemVer proper. |
ref #341