refector: Drop usage of xml_set_object()#152
Merged
k00ni merged 2 commits intosemsol:masterfrom Oct 20, 2023
Girgias:remove-set-xml-usage
Merged
refector: Drop usage of xml_set_object()#152k00ni merged 2 commits intosemsol:masterfrom Girgias:remove-set-xml-usage
k00ni merged 2 commits intosemsol:masterfrom
Girgias:remove-set-xml-usage
Conversation
Use proper callables instead. Related to: php/php-src#12340
Contributor
Author
|
PHP_CS_FIXER warning is unrelated to this PR and a pre-existing issue. |
Collaborator
|
Thank you @Girgias. I am super busy currently, but I will look into that soonish. PR looks good at first glance, but I may have to fix our CI before a merge because only coding style check ran. |
k00ni
approved these changes
Oct 20, 2023
Collaborator
|
Thank you @Girgias |
Contributor
Author
|
Glad to help :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use proper callables instead.
Related to: php/php-src#12340