Skip to content

test(integration): properly waited for the image pulls to complete#2842

Merged
gr2m merged 1 commit intomasterfrom
docker-pull
Jun 26, 2023
Merged

test(integration): properly waited for the image pulls to complete#2842
gr2m merged 1 commit intomasterfrom
docker-pull

Conversation

@travi
Copy link
Copy Markdown
Member

@travi travi commented Jun 20, 2023 •
edited
Loading

this uses the technique for waiting for the pull to complete from the dockerode readme and mostly gets rid of our dependence on get-stream.

the remaining get-stream usage is the .array() that is removed in v7. i suggest we deal with that usage separately from this PR

@travi travi marked this pull request as draft June 20, 2023 04:51
@travi
Copy link
Copy Markdown
Member Author

travi commented Jun 20, 2023

it appears that the pulls are happening before each test in the integration file. would be better to do the pulls before the overall suite run so that they only happen once

@travi
Copy link
Copy Markdown
Member Author

travi commented Jun 20, 2023

it appears that the pulls are happening before each test in the integration file. would be better to do the pulls before the overall suite run so that they only happen once

i was wrong. it is using test.before, not test.beforeEach, so this should already be correct. since we are actually fully waiting for the pulls, we may need to extend the timeout for the integration test, though

@travi travi force-pushed the docker-pull branch 3 times, most recently from f7feb95 to c9e1b99 Compare June 24, 2023 04:49
@travi travi marked this pull request as ready for review June 24, 2023 04:53
@travi
Copy link
Copy Markdown
Member Author

travi commented Jun 24, 2023

it looks like this change does not fix the flakiness, but i think it is still a worthwhile change to get merged

@gr2m gr2m merged commit e39ae90 into master Jun 26, 2023
@gr2m gr2m deleted the docker-pull branch June 26, 2023 00:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 28, 2023

🎉 This PR is included in version 21.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@travi @gr2m