Skip to content

refactor(esm): converted the package to esm#297

Merged
travi merged 13 commits intomasterfrom
esm
Apr 28, 2023
Merged

refactor(esm): converted the package to esm#297
travi merged 13 commits intomasterfrom
esm

Conversation

@travi
Copy link
Copy Markdown
Member

@travi travi commented Dec 10, 2021

fixes #296

BREAKING CHANGE: @semantic-release/npm is now a native ES Module. It has
named exports for each plugin hook (generateNotes)

@travi
Copy link
Copy Markdown
Member Author

travi commented Dec 10, 2021

remaining work:

  • verification of the changelogContext details passed to the conventional-changelog-writer is not working like the previous spy did
  • replace xo with prettier

fixes #296

BREAKING CHANGE: `@semantic-release/release-notes-generator` is now a native ES Module. It has
named exports for each plugin hook (`generateNotes`)
@travi
Copy link
Copy Markdown
Member Author

travi commented Feb 3, 2023

capturing this observation since it didnt dawn on me quickly and might escape me if i come back to this later. the previous version of the integration tests simply spied on the conventional-changelog-writer rather than fully replacing with a double. the tests are structured to expect the writer to execute fully while simply observing the arguments passed to it. using td.replaceEsm is probably going too far in this case.

@travi
Copy link
Copy Markdown
Member Author

travi commented Apr 14, 2023

confirmation that spying on, but calling through to the original does not align with the philosophy for testdouble: testdouble/testdouble.js#219

@travi travi marked this pull request as ready for review April 28, 2023 19:21
@travi travi requested a review from gr2m April 28, 2023 19:28
@travi travi merged commit 38a10fe into master Apr 28, 2023
@travi travi deleted the esm branch April 28, 2023 19:56
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ES Module

2 participants