Performance upgrade for updateOriginalInput() #910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, on every call to updateOriginalInput(), a brand new array of options for every value in selectize.items would be created and the entire HTML string would replace all children of the raw input source. When doing something like selectize.addItems(_.keys(selectize.options)); for a few hundred options, this becomes very sluggish. This takes a smarter approach, only removing and adding individual options from the input source as necessary. The bottleneck is the repeated use of jQuery's html() method with large DOM updates. For ~300 options this was originally taking 30154ms in appendChild. Now it spends only 330.9ms.
|
+1 thank you for this. Using the drag-and-drop plugin on more than 10 items was unbearably slow, this fixes it. Nice work. |
Contributor
Author
|
@andrewbaldock I fixed a bug (see above commit) with a blank/default option being added in situations where the select wasn't actually without options. |
Contributor
Author
|
Closing this in favor of #1460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on every call to
updateOriginalInput(), a brand new array ofoptions for every value in
selectize.itemswould be created and theentire HTML string would replace all children of the raw input source.
When doing something like
for a few hundred options, this becomes very sluggish.
This PR takes a smarter approach, only removing and adding individual
options from the input source as necessary.
The bottleneck is the repeated use of jQuery's
html()method with largeDOM updates. For ~300 options this was originally spending 30154ms in
appendChild. Now it spends only 330.9ms.