fix(types): Property 'All' is optional but undefined not allowed#82
Merged
silesky merged 1 commit intosegmentio:masterfrom Apr 21, 2023
Merged
fix(types): Property 'All' is optional but undefined not allowed#82silesky merged 1 commit intosegmentio:masterfrom
silesky merged 1 commit intosegmentio:masterfrom
Conversation
Contributor
Author
|
@dk1027 @danieljackins @juliofarah can you have a look on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #69
This type is not useful because it says something like:
But
Allis a string!So not all strings can be undefined, only
Allwhy?That means :
Since this does not make sense and TS is also saying this 2 rules can not match each other we have to change the Type.
With this PR I introduce the new types by removing the
Allrule. So now we can pass in all strings, also the stringAllbut the values can only betrueorfalse. If you don't want to pass theAllkey, just do not pass it in the integrations object.So now the following is the case: