Skip to content

Migrate from CircleCI -> to github actions, yarn, fix CI#137

Merged
silesky merged 5 commits intomasterfrom
switch-to-gh-actions
Oct 12, 2023
Merged

Migrate from CircleCI -> to github actions, yarn, fix CI#137
silesky merged 5 commits intomasterfrom
switch-to-gh-actions

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Oct 11, 2023

  • add GH actions
  • switch to yarn
  • fix CI error

@silesky silesky closed this Oct 11, 2023
@silesky silesky reopened this Oct 11, 2023
@silesky silesky force-pushed the switch-to-gh-actions branch 2 times, most recently from a53287a to 36c7a2d Compare October 11, 2023 23:30
@silesky silesky changed the title add gh actions Migrate to github actions, yarn, fix CI Oct 11, 2023
@silesky silesky force-pushed the switch-to-gh-actions branch from 36c7a2d to 676625f Compare October 11, 2023 23:35
@silesky silesky changed the title Migrate to github actions, yarn, fix CI Migrate from CircleCI -> to github actions, yarn, fix CI Oct 11, 2023
@silesky silesky requested review from chrisradek and pooyaj October 11, 2023 23:39
@silesky silesky requested review from danieljackins and oscb October 11, 2023 23:55
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. With this move, will we be able to automate publishing relatively easily again?

@silesky
Copy link
Contributor Author

silesky commented Oct 12, 2023

This looks reasonable to me. With this move, will we be able to automate publishing relatively easily again?

Definitely, though FYI that was before my time... I only disabled because nobody was actually using it. Looks like a long time ago they supported the "checkout master + version and push tag" strategy, which would be easy to resurrect.

I updated the README a few months ago https://github.com/segmentio/snippet#publishing-to-npm

could make that simple flow a bit better with a tool like "release-it"

@silesky silesky merged commit 95ae94c into master Oct 12, 2023
@silesky silesky deleted the switch-to-gh-actions branch October 12, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants