Skip to content

make stale reference-proof #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silesky merged 5 commits into from
Apr 15, 2023
Merged

make stale reference-proof #116

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a44b13d
make stale reference proof
silesky Mar 30, 2023
5457e71
add comment
silesky Mar 30, 2023
a2c0adc
change to non minified method name
silesky Mar 31, 2023
9cf92c9
Update template/snippet.js
silesky Mar 31, 2023
6781b65
move up
silesky Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions template/snippet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@
// stored as the first argument, so we can replay the data.
analytics.factory = function(method){
return function(){
if (window.analytics.initialized) {
// Sometimes users assigned analytics to a variable before analytics is done loading, resulting in a stale reference.
// If so, proxy any calls to the 'real' analytics instance.
return window.analytics[method].apply(window.analytics, arguments);
}
var args = Array.prototype.slice.call(arguments);
args.unshift(method);
analytics.push(args);
Expand Down