@GCandrew yes! The default value of noUnhandledRejection should be false IMHO, my main concerns right now is how setting it to true will break the retry behavior, we should let axios-retry do its thing before handling any rejection.

To be honest I completely forgot about 'axios-retry' being used and after going over how that works [1] now I think some changes maybe necessary in either the tests, your PR or both.

axios-retry documentation does not mention any way to capture the "final error", at that moment we could handle the exception and avoid an unhandled rejection, possibly something like [2].

I will try with my suggested try-catch changes and let you know if they work, let me know if you see a better way.

[1]

axios-retry catches any error and then checks if it is possible to retry
axios-retry will then return a promise with a delay or reject

[2]

  flush (callback) {
    ....
    try {
      return await this.axiosInstance.post(`${this.host}${this.path}`, data, req)
        .then(() => {
          done()
          return Promise.resolve(data)
        })
        .catch(err => {
          if (err.response) {
            const error = new Error(err.response.statusText)
            done(error)
            throw error
          }

          done(err)
          throw err
        })
    } catch (err) {
        if (!this.noUnhandledRejection) {
          throw err
        }
    }
  }

Unhandled Promise Rejection Can Crash App #326

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions