Skip to content

Add option to include target domain in subfinder findings #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
J12934 merged 4 commits into from
Jan 14, 2026
Merged

Add option to include target domain in subfinder findings #3452

J12934 merged 4 commits into from
Jan 14, 2026
+615 −29

Conversation

@p4trickweiss
Copy link
Contributor

@p4trickweiss p4trickweiss commented Jan 8, 2026 •
edited
Loading

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@netlify
Copy link

netlify bot commented Jan 8, 2026 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 1899575
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/69675529d8d8a40008629253

@p4trickweiss p4trickweiss requested a review from J12934 January 8, 2026 09:39
Reet00
Reet00 reviewed Jan 9, 2026
View reviewed changes
@p4trickweiss p4trickweiss force-pushed the subfinder-targetdomain branch from fc2053d to 50bc34b Compare January 13, 2026 10:05
@Weltraumschaf Weltraumschaf moved this from Triage to To Review in secureCodeBox Jan 13, 2026
@p4trickweiss
Add option to include target domain in subfinder findings
9e0f188 
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
@p4trickweiss
Add parser test
e90b39f 
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
@p4trickweiss
Refactor extractDomainFromArgs
aeb3e3c 
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
@p4trickweiss p4trickweiss force-pushed the subfinder-targetdomain branch from 50bc34b to aeb3e3c Compare January 14, 2026 08:21
@p4trickweiss
Make RegEx more readable
1899575 
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 14, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
34.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-project-automation github-project-automation bot moved this from To Review to Reviewer Approved in secureCodeBox Jan 14, 2026
@J12934 J12934 merged commit 77f3b39 into secureCodeBox:main Jan 14, 2026
47 of 48 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in secureCodeBox Jan 14, 2026
@J12934 J12934 added the enhancement New feature or request label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reet00 Reet00 Reet00 left review comments

@J12934 J12934 J12934 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@p4trickweiss @J12934 @Reet00