Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes and improvements from integrating the new Boomerang version into CryptoAnalysis:
TransitionFunctionImplstored the state changing transitions and state changing statement in two separate sets. This does not allow us to connect corresponding transitions and statements. Solution: Use a Map to map the transitions to their statements. For example, assuming a state machine0 -[ new A() ]-> 1 -[ op ]-> 2in the programthe current solution just stores the sets
{[0->1], [0->2]}and{<init>, op}. With the map, we have the mapping{[0->1] -> <init>, [0->2] -> op}, giving us the information that state1is reached with the call to<init>and state2is reached with the call toop