Generalize the scopes to make them more consistent#149
Merged
Conversation
Hazem-Gamall
reviewed
May 5, 2025
boomerangScope-Soot/src/main/java/boomerang/scope/soot/SootCallGraph.java
Outdated
Show resolved
Hide resolved
Hazem-Gamall
approved these changes
May 5, 2025
swissiety
approved these changes
May 5, 2025
Member
swissiety
left a comment
There was a problem hiding this comment.
great work - I guess I would not have passed around the scene singleton for Soot as this will most likely never be anything else than a global singleton.
boomerangPDS/src/main/java/boomerang/poi/ExecuteImportFieldStmtPOI.java
Outdated
Show resolved
Hide resolved
Hazem-Gamall
approved these changes
May 5, 2025
Collaborator
Author
|
@swissiety I added the suggested changes. I added the Scene object just to be consistent. It is also easier to document the scopes, e.g. "Each scope has a "master" object (Scene, View, Project) that is passed between the scope objects" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the addition of the Opal scope, we had to refactor some parts in the scope structure because it was optimized for Soot. This PR contains some more internal refactoring to make the scopes more consistent:
Close #130
Close #134