Conversation
implementation Fixed by following `UPGRADE` guide: https://github.com/RustAudio/rodio/blob/master/UPGRADE.md and CHANGELOG https://github.com/RustAudio/rodio/blob/master/CHANGELOG.md Breaking changes in rodio 0.21: - `OutputStream` API changed to `OutputStreamBuilder` - `Sink::try_new()` replaced with `mixer.add()` pattern - `Decoder` now uses `try_from()` instead of `new()` Implementation changes (`--features sound` only): - Store persistent `Sound` instance in `App` with long-lived `OutputStream` - Buffer decoded audio once at initialization (stored in `Arc<Buffered<Decoder>>`) - Use non-blocking `mixer.add()` instead of `Sink` with threaded playback - Remove redundant file validation in `sound.rs` (already done in `args.rs`) Fixes "Dropping OutputStream" warnings and improves performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #144 we upgraded
radio0.20.1->0.21.1, which breaks currentsoundimplementation.This PR fixes it by following
rodiosUPGRADEandCHANGELOGguides.rodio0.21:OutputStreamAPI changed toOutputStreamBuilderSink::try_new()replaced withmixer.add()patternDecodernow usestry_from()instead ofnew()Soundinstance inAppwith long-livedOutputStreamArc<Buffered<Decoder>>)mixer.add()instead ofSinkwith threaded playbacksound.rs(already done inargs.rs)