Skip to content

Add DeviceControl packet to GMLAN#3036

Merged
guedou merged 2 commits intosecdev:masterfrom
polybassa:gmlan_dc_packet
Jan 4, 2021
Merged

Add DeviceControl packet to GMLAN#3036
guedou merged 2 commits intosecdev:masterfrom
polybassa:gmlan_dc_packet

Conversation

@polybassa
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 27, 2020

Codecov Report

Merging #3036 (ea1b7c0) into master (b140d07) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
- Coverage   85.37%   85.36%   -0.02%     
==========================================
  Files         255      255              
  Lines       53977    53992      +15     
==========================================
+ Hits        46085    46089       +4     
- Misses       7892     7903      +11     
Impacted Files Coverage Δ
scapy/contrib/automotive/gm/gmlan.py 92.33% <85.71%> (-0.36%) ⬇️
scapy/layers/can.py 94.63% <0.00%> (-1.45%) ⬇️
scapy/arch/windows/__init__.py 68.25% <0.00%> (-0.58%) ⬇️
scapy/data.py 87.85% <0.00%> (-0.52%) ⬇️
scapy/layers/inet.py 65.89% <0.00%> (-0.16%) ⬇️
scapy/layers/tls/automaton_cli.py 70.82% <0.00%> (-0.14%) ⬇️
scapy/layers/dot11.py 90.53% <0.00%> (-0.04%) ⬇️
scapy/fields.py 91.48% <0.00%> (-0.01%) ⬇️
scapy/utils.py 78.91% <0.00%> (+0.01%) ⬆️
scapy/contrib/automotive/uds.py 91.29% <0.00%> (+0.42%) ⬆️

guedou
guedou previously approved these changes Jan 3, 2021
Copy link
Copy Markdown
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it something that can be tested in a unit test?

@polybassa
Copy link
Copy Markdown
Contributor Author

sorry. Tests added.

@guedou guedou merged commit 6f0958e into secdev:master Jan 4, 2021
@polybassa polybassa deleted the gmlan_dc_packet branch July 27, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants