Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3035 +/- ##
==========================================
- Coverage 85.37% 85.36% -0.01%
==========================================
Files 255 255
Lines 53977 53976 -1
==========================================
- Hits 46085 46079 -6
- Misses 7892 7897 +5
|
guedou
reviewed
Jan 1, 2021
|
|
||
| @staticmethod | ||
| def get_log(pkt): | ||
| # type: (UDS_DSC) -> Tuple[str, Any] |
Member
There was a problem hiding this comment.
Can we do better than using Any here?
Contributor
Author
There was a problem hiding this comment.
I'm currently working on a huge refactoring of my code which uses this log functions. Also this scanner code on the bottom of this file will move in a new file. After I've this code ready, I would focus on typing of this layer. Hope that works for now.
guedou
approved these changes
Jan 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.