Fix MultipleTypeField initialization#1550
Merged
p-l- merged 1 commit intosecdev:masterfrom Aug 15, 2018
gpotter2:multit-fix
Merged
Fix MultipleTypeField initialization#1550p-l- merged 1 commit intosecdev:masterfrom gpotter2:multit-fix
p-l- merged 1 commit intosecdev:masterfrom
gpotter2:multit-fix
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 85.34% 85.55% +0.21%
==========================================
Files 176 176
Lines 40820 41237 +417
==========================================
+ Hits 34837 35281 +444
+ Misses 5983 5956 -27
|
Merged
Member
|
@p-l- you might want to review that PR. |
guedou
approved these changes
Aug 14, 2018
Member
|
Unfortunately this does not fix #642 =/ |
p-l-
requested changes
Aug 14, 2018
scapy/packet.py
Outdated
Member
There was a problem hiding this comment.
Nice job!
I'd just replace the following lines with (use .pop(), longer / more explicit variable names, _ for unused element):
for field in self.fields_desc:
fname = field.name
try:
value = fields.pop(fname)
except KeyError:
continue
self.fields[fname] = self.get_field(f).any2i(self, value)
for fname, _ in fields:
raise AttributeError(fname)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a second (and cleaner) attempt to fix #1484
fixes #1484