Consider imported Go type lives in the same package if no mapping provided #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided This commit allows referencing imported types living in the same go package. We consider no import is necessary if no import mapping is provided for the remote reference, and reference the go type by its name (no import path). Downside of this approach: no error is returned if the user accidentally forget or messes up the import mapping. Code compilation will likely fail instead. Fixes oapi-codegen#400.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows referencing imported types living in the same go package.
We consider no import is necessary if no import mapping is provided for the
remote reference, and reference the go type by its name (no import path).
Downside of this approach: no error is returned if the user accidentally forget
or messes up the import mapping. Code compilation will likely fail instead.
Fixes oapi-codegen#400.