Fix teamcity logging#6064
Closed
asika32764 wants to merge 1511 commits intosebastianbergmann:10.5from
Closed
Conversation
Co-authored-by: Sebastian Bergmann <sb@sebastian-bergmann.de> Co-authored-by: Fabian Blechschmidt <github@fabian-blechschmidt.de> Co-authored-by: Arne Blankerts <arne@blankerts.de> Co-authored-by: Markus Staab <markus.staab@redaxo.de> Co-authored-by: Nicola Pilcher <nicola.pilcher@gmail.com> Co-authored-by: Andreas Möller <am@localheinz.com> Co-authored-by: Sebastian Heuer <sebastian@phpeople.de>
Owner
|
As the proposed changes fix a bug, this pull request should target the oldest affected/supported branch, which is May I kindly ask you to 1) squash your changes into a single commit (with commit message |
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
Owner
There was a problem hiding this comment.
This looks wrong and unrelated.
| /** | ||
| * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit | ||
| * @no-named-arguments Parameter names are not covered by the backward compatibility promise for | ||
| * PHPUnit |
Owner
There was a problem hiding this comment.
This looks wrong and unrelated.
| * PHPUnit | ||
| * | ||
| * @internal This class is not covered by the backward compatibility promise for PHPUnit | ||
| * @internal This class is not covered by the backward compatibility promise for PHPUnit |
Owner
There was a problem hiding this comment.
This looks wrong and unrelated.
Owner
|
I am sorry, but I cannot review this in its current state. Please do not make any unrelated (whitespace) changes and make sure to run |
Contributor
Author
|
As the 10.5 is far away from 11.4, I re-open a new PR for it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5354
This is a very simple workarounds to fix PhpStorm unit test output.
Before
After
Currently I'm not totally understand the emitter system of phpunit, so I'm not able to add the test ignored message for every methods, only fix the class level skipped actions.