Skip to content

Do not fail with "An error occurred inside PHPUnit" when data provider key is not int or string#5942

Merged
sebastianbergmann merged 3 commits intosebastianbergmann:10.5from
6b7562617765726c6f73:fix_data_provider_key_check
Sep 8, 2024
Merged

Do not fail with "An error occurred inside PHPUnit" when data provider key is not int or string#5942
sebastianbergmann merged 3 commits intosebastianbergmann:10.5from
6b7562617765726c6f73:fix_data_provider_key_check

Conversation

@kubawerlos
Copy link
Copy Markdown
Contributor

Fixes #4625

@kubawerlos kubawerlos changed the base branch from main to 10.5 September 7, 2024 18:11
@kubawerlos kubawerlos closed this Sep 7, 2024
@kubawerlos kubawerlos reopened this Sep 7, 2024
@kubawerlos kubawerlos force-pushed the fix_data_provider_key_check branch from 7491595 to 914aca3 Compare September 7, 2024 18:22
@kubawerlos kubawerlos force-pushed the fix_data_provider_key_check branch from 914aca3 to 16f8bdb Compare September 7, 2024 18:30
@kubawerlos kubawerlos marked this pull request as ready for review September 7, 2024 18:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (cdac775) to head (ce29d42).
Report is 3 commits behind head on 10.5.

Additional details and impacted files
@@            Coverage Diff            @@
##               10.5    #5942   +/-   ##
=========================================
  Coverage     94.14%   94.14%           
- Complexity     6435     6436    +1     
=========================================
  Files           678      678           
  Lines         19417    19423    +6     
=========================================
+ Hits          18280    18286    +6     
  Misses         1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann added type/bug Something is broken feature/test-runner CLI test runner feature/data-provider Data Providers labels Sep 8, 2024
@sebastianbergmann sebastianbergmann merged commit 4adfe6c into sebastianbergmann:10.5 Sep 8, 2024
@kubawerlos kubawerlos deleted the fix_data_provider_key_check branch September 8, 2024 10:34
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature/data-provider Data Providers feature/test-runner CLI test runner type/bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generator yielding keys that are neither integer or string leads to hard-to-understand error message when used as data provider

2 participants