Skip to content

Fix testdox output containing dollar signs in the value from data provider#5940

Merged
sebastianbergmann merged 3 commits intosebastianbergmann:10.5from
6b7562617765726c6f73:fix_with_dollar_sign
Sep 6, 2024
Merged

Fix testdox output containing dollar signs in the value from data provider#5940
sebastianbergmann merged 3 commits intosebastianbergmann:10.5from
6b7562617765726c6f73:fix_with_dollar_sign

Conversation

@kubawerlos
Copy link
Copy Markdown
Contributor

Fixes #5929

@sebastianbergmann sebastianbergmann added type/bug Something is broken feature/testdox The TextDox printer/formatter feature/test-runner CLI test runner labels Sep 5, 2024
@kubawerlos kubawerlos force-pushed the fix_with_dollar_sign branch 2 times, most recently from 3add671 to 97a37be Compare September 5, 2024 18:52
@kubawerlos kubawerlos changed the base branch from main to 8.5 September 5, 2024 18:57
@kubawerlos kubawerlos marked this pull request as ready for review September 5, 2024 19:10
@sebastianbergmann
Copy link
Copy Markdown
Owner

I am sorry, but PHPUnit 8 (and PHPUnit 9) do not get bug fixes anymore.

Please send this against the 10.5 branch. Thank you!

@kubawerlos kubawerlos changed the base branch from 8.5 to 10.5 September 6, 2024 07:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (f069f46) to head (5052003).
Report is 3 commits behind head on 10.5.

Additional details and impacted files
@@            Coverage Diff            @@
##               10.5    #5940   +/-   ##
=========================================
  Coverage     94.14%   94.14%           
  Complexity     6434     6434           
=========================================
  Files           678      678           
  Lines         19414    19414           
=========================================
  Hits          18277    18277           
  Misses         1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kubawerlos
Copy link
Copy Markdown
Contributor Author

I am sorry, but PHPUnit 8 (and PHPUnit 9) do not get bug fixes anymore.

My bad, I should read the descriptions there, not only look at the colours.

Please send this against the 10.5 branch. Thank you!

Done

@sebastianbergmann sebastianbergmann merged commit f2327b6 into sebastianbergmann:10.5 Sep 6, 2024
@kubawerlos kubawerlos deleted the fix_with_dollar_sign branch September 6, 2024 09:27
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature/test-runner CLI test runner feature/testdox The TextDox printer/formatter type/bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestDox output containing $ at the beginning gets truncated when used with a data provider

2 participants