Assertions for comparing arrays while ignoring a specified list of keys#5600
Closed
sebastianbergmann wants to merge 2 commits intomainfrom
Closed
Assertions for comparing arrays while ignoring a specified list of keys#5600sebastianbergmann wants to merge 2 commits intomainfrom
sebastianbergmann wants to merge 2 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5600 +/- ##
============================================
+ Coverage 88.46% 88.47% +0.01%
- Complexity 6258 6272 +14
============================================
Files 668 668
Lines 20047 20071 +24
============================================
+ Hits 17734 17758 +24
Misses 2313 2313 ☔ View full report in Codecov by Sentry. |
assertArrayIsEqualToArrayIgnoringKeys() and assertArrayIsIdenticalToArrayIgnoringKeys()036b3bf to
a505e63
Compare
…enticalToArrayIgnoringKeys()
…sertArrayIsIdenticalToArrayOnlyConsideringListOfKeys()
a505e63 to
2722a9c
Compare
11 tasks
This was referenced Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the
assertArrayIsEqualToArrayIgnoringListOfKeys()andassertArrayIsIdenticalToArrayIgnoringListOfKeys()assertions that compare two arrays while ignoring a list of keys. This is useful when the arrays that are to be compared contain date/time-dependent or random information.This also implements the
assertArrayIsEqualToArrayOnlyConsideringListOfKeys()andassertArrayIsEqualToArrayOnlyConsideringListOfKeys()assertions that assert that two arrays are equal (or identical, respectively) while only considering a list of keys. This is useful when there are more keys to be ignored (see above) than to actually be considered for the comparison.I am reluctant to add new assertions, but the use cases they address have been brought up a couple of times recently, so maybe they should be added.