Skip to content

Fix: Enable required extensions only#4759

Merged
sebastianbergmann merged 1 commit intosebastianbergmann:8.5from
localheinz:fix/extension
Oct 17, 2021
Merged

Fix: Enable required extensions only#4759
sebastianbergmann merged 1 commit intosebastianbergmann:8.5from
localheinz:fix/extension

Conversation

@localheinz
Copy link
Copy Markdown
Collaborator

@localheinz localheinz commented Aug 13, 2021 •
edited
Loading

@localheinz localheinz added the type/build-automation Issues related to PHPUnit's build automation (GitHub Actions, etc.) label Aug 13, 2021
@localheinz localheinz self-assigned this Aug 13, 2021
@localheinz localheinz force-pushed the fix/extension branch 5 times, most recently from abceda4 to 40151a8 Compare August 13, 2021 16:36
@sebastianbergmann
Copy link
Copy Markdown
Owner

sebastianbergmann commented Aug 14, 2021

Looks like we need more extensions for running tools on PHPUnit's code than for running PHPUnit's code.

@localheinz localheinz mentioned this pull request Aug 24, 2021
Closed
1 task
@localheinz localheinz force-pushed the fix/extension branch 10 times, most recently from 34b57f5 to 924a203 Compare August 27, 2021 08:54
@localheinz localheinz mentioned this pull request Aug 27, 2021
Merged
1 task
@localheinz
Copy link
Copy Markdown
Collaborator Author

localheinz commented Sep 13, 2021

@sebastianbergmann

Looks like @shivammathur has released the feature, I will update accordingly!

@localheinz localheinz force-pushed the fix/extension branch 4 times, most recently from b93b71f to c281850 Compare September 18, 2021 21:33
@localheinz
Copy link
Copy Markdown
Collaborator Author

localheinz commented Sep 18, 2021

@sebastianbergmann

Not sure about https://github.com/sebastianbergmann/phpunit/pull/4759/checks?check_run_id=3642020648 - do you have an idea?

@localheinz localheinz force-pushed the fix/extension branch 4 times, most recently from 2631cf4 to 327513d Compare October 17, 2021 10:11
@localheinz localheinz marked this pull request as ready for review October 17, 2021 10:16
@localheinz
Copy link
Copy Markdown
Collaborator Author

localheinz commented Oct 17, 2021

@sebastianbergmann

This looks good, I think - the builds that are failing here are also failing for all other open pull requests:

2021-10-17T10:14:21.7173330Z [php-scoper] 
2021-10-17T10:14:21.7174015Z [php-scoper] 
2021-10-17T10:14:21.7174534Z [php-scoper]     ____  __  ______     _____
2021-10-17T10:14:21.7175098Z [php-scoper]    / __ \/ / / / __ \   / ___/_________  ____  ___  _____
2021-10-17T10:14:21.7175685Z [php-scoper]   / /_/ / /_/ / /_/ /   \__ \/ ___/ __ \/ __ \/ _ \/ ___/
2021-10-17T10:14:21.7176247Z [php-scoper]  / ____/ __  / ____/   ___/ / /__/ /_/ / /_/ /  __/ /
2021-10-17T10:14:21.7176837Z [php-scoper] /_/   /_/ /_/_/       /____/\___/\____/ .___/\___/_/
2021-10-17T10:14:21.7177406Z [php-scoper]                                      /_/
2021-10-17T10:14:21.7177875Z [php-scoper] 
2021-10-17T10:14:21.7178487Z [php-scoper] PHP Scoper version 0.15.0 2021-05-10 21:02:42 UTC
2021-10-17T10:14:21.7179020Z [php-scoper] 
2021-10-17T10:14:21.7330898Z [php-scoper] 
2021-10-17T10:14:21.7332389Z [php-scoper] 
2021-10-17T10:14:21.7333352Z [php-scoper]  // Memory usage: 13.28MB (peak: 17.11MB), time: 0.02s                          
2021-10-17T10:14:21.7334347Z [php-scoper] 
2021-10-17T10:14:21.7347566Z [php-scoper]    0/699 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
2021-10-17T10:14:21.7356676Z [php-scoper]  699/699 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
2021-10-17T10:14:21.7358340Z [php-scoper] In AddPrefixCommand.php line 118:
2021-10-17T10:14:21.7359516Z [php-scoper]                                                                                
2021-10-17T10:14:21.7360591Z [php-scoper]   Could not parse the file "/home/runner/work/phpunit/phpunit/build/tmp/phar/  
2021-10-17T10:14:21.7361659Z [php-scoper]   doctrine-instantiator/Doctrine/Instantiator/Instantiator.php".               
2021-10-17T10:14:21.7362497Z [php-scoper]                                                                                
2021-10-17T10:14:21.7363002Z [php-scoper] 
2021-10-17T10:14:21.7363718Z [php-scoper] In Lexer.php line 197:
2021-10-17T10:14:21.7365249Z [php-scoper]                            
2021-10-17T10:14:21.7365978Z [php-scoper]   Undefined array key 288  
2021-10-17T10:14:21.7366671Z [php-scoper]                            
2021-10-17T10:14:21.7367270Z [php-scoper] 
2021-10-17T10:14:21.7368725Z [php-scoper] add-prefix [-d|--working-dir WORKING-DIR] [-p|--prefix PREFIX] [-o|--output-dir OUTPUT-DIR] [-f|--force] [-s|--stop-on-failure] [-c|--config CONFIG] [--no-config] [--] [<paths>...]
2021-10-17T10:14:21.7369687Z [php-scoper] 
2021-10-17T10:14:21.7480074Z [php-scoper] Result: 1

@sebastianbergmann sebastianbergmann merged commit 273b23a into sebastianbergmann:8.5 Oct 17, 2021
@sebastianbergmann
Copy link
Copy Markdown
Owner

sebastianbergmann commented Oct 17, 2021

Thanks!

@localheinz localheinz deleted the fix/extension branch October 17, 2021 15:35
@localheinz
Copy link
Copy Markdown
Collaborator Author

localheinz commented Oct 17, 2021

Thank you, @sebastianbergmann!

This was referenced Dec 31, 2021
Merged
Merged
Merged
Merged
@localheinz localheinz mentioned this pull request Feb 7, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastianbergmann sebastianbergmann Awaiting requested review from sebastianbergmann

Assignees

@localheinz localheinz

Labels

type/build-automation Issues related to PHPUnit's build automation (GitHub Actions, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@localheinz @sebastianbergmann