Skip iteration when only one name needs to be mapped to a unit of code

sebastianbergmann · sebastianbergmann · commit fe9f3b1e1ee4 · 2024-03-13T16:06:40.000+01:00
diff --git a/src/Metadata/Api/CodeCoverage.php b/src/Metadata/Api/CodeCoverage.php
@@ -247,14 +247,20 @@ private function mapToCodeUnits(CoversClass|CoversFunction|CoversMethod|UsesClas
             }
         }
 
-        $codeUnits = CodeUnitCollection::fromList();
-
         try {
+            if (count($names) === 1) {
+                return $mapper->stringToCodeUnits($names[0]);
+            }
+
+            $codeUnits = CodeUnitCollection::fromList();
+
             foreach ($names as $name) {
                 $codeUnits = $codeUnits->mergeWith(
                     $mapper->stringToCodeUnits($name),
                 );
             }
+
+            return $codeUnits;
         } catch (CodeUnitException $e) {
             if ($metadata->isCoversClass() || $metadata->isUsesClass()) {
                 if (interface_exists($metadata->className())) {
@@ -276,7 +282,5 @@ private function mapToCodeUnits(CoversClass|CoversFunction|CoversMethod|UsesClas
                 $e,
             );
         }
-
-        return $codeUnits;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -247,14 +247,20 @@ private function mapToCodeUnits(CoversClass\|CoversFunction\|CoversMethod\|UsesClas`
`247`	`247`	`}`
`248`	`248`	`}`
`249`	`249`
`250`		`- $codeUnits = CodeUnitCollection::fromList();`
`251`		`-`
`252`	`250`	`try {`
	`251`	`+ if (count($names) === 1) {`
	`252`	`+ return $mapper->stringToCodeUnits($names[0]);`
	`253`	`+ }`
	`254`	`+`
	`255`	`+ $codeUnits = CodeUnitCollection::fromList();`
	`256`	`+`
`253`	`257`	`foreach ($names as $name) {`
`254`	`258`	`$codeUnits = $codeUnits->mergeWith(`
`255`	`259`	`$mapper->stringToCodeUnits($name),`
`256`	`260`	`);`
`257`	`261`	`}`
	`262`	`+`
	`263`	`+ return $codeUnits;`
`258`	`264`	`} catch (CodeUnitException $e) {`
`259`	`265`	`if ($metadata->isCoversClass() \|\| $metadata->isUsesClass()) {`
`260`	`266`	`if (interface_exists($metadata->className())) {`
`@@ -276,7 +282,5 @@ private function mapToCodeUnits(CoversClass\|CoversFunction\|CoversMethod\|UsesClas`
`276`	`282`	`$e,`
`277`	`283`	`);`
`278`	`284`	`}`
`279`		`-`
`280`		`- return $codeUnits;`
`281`	`285`	`}`
`282`	`286`	`}`