Drop DOM dependency in XML Report by staabm · Pull Request #1125 · sebastianbergmann/php-code-coverage

staabm · 2025-11-22T08:15:47Z

before this PR (using PHPUnit 12.4.4)

➜  slow-coverage-xml1 git:(main) ✗ hyperfine 'php coverage-xml.php'           
Benchmark 1: php coverage-xml.php
  Time (mean ± σ):     11.772 s ±  0.550 s    [User: 10.209 s, System: 1.237 s]
  Range (min … max):   11.008 s … 12.568 s    10 runs

after this PR:

➜  slow-coverage-xml1 git:(main) ✗ hyperfine 'php coverage-xml.php'
Benchmark 1: php coverage-xml.php
  Time (mean ± σ):      5.999 s ±  0.385 s    [User: 5.008 s, System: 0.789 s]
  Range (min … max):    5.647 s …  6.732 s    10 runs

env

php -v
PHP 8.3.28 (cli) (built: Nov 18 2025 22:17:16) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.28, Copyright (c) Zend Technologies

staabm · 2025-11-22T10:10:44Z

double check against phpstan-src@05b80ef861 on my macos m4 pro laptop

before this PR (using PHPUnit 12.4.4)

Generating code coverage report in PHPUnit XML format ... done [00:31.317]

after this PR

Generating code coverage report in PHPUnit XML format ... done [00:17.598]

sebastianbergmann · 2025-11-26T17:27:52Z

Does Infection need the <source> element? If not, we could speed up the XML report generation even more for that use case:

❯ git diff
src/Report/Xml/Facade.php --- 1/2 --- PHP
45        public const string XML_NAMESPACE = 'https://schema.phpunit.de/coverage/1.0';
46        private string $target;
47        private Project $project;
48        private readonly string $phpUnitVersion;
50        public function __construct(string $version)
   49     private readonly bool $includeSource;
   51     public function __construct(string $version, bool $includeSource = true)
   54         $this->includeSource  = $includeSource;
   55     }
   56
   57     /**
   58      * @throws XmlException

src/Report/Xml/Facade.php --- 2/2 --- PHP
169                $coverage = $fileReport->lineCoverage((string) $line);
170                $coverage->finalize($tests);
171            }
   175         if ($this->includeSource) {
   179         }
   180
   181         $this->saveDocument($fileReport->asDom(), $file->id());
   182     }
   183

Of course, we would need to expose this as a configuration option. This is just an idea so far.

staabm · 2025-11-27T07:01:43Z

Does Infection need the <source> element? If not, we could speed up the XML report generation even more for that use

great idea.

I did some testing and it seems the source element is not required for infection. will double check with the infection team though.

I also did some perf testing on phpstan-src and I can see a ~15% perf improvement when source is not at all generated.

I think we should tackle this in a separate PR though

for this PR here to continue we need a release of the xml-tokenizer including theseer/tokenizer#38 though

sebastianbergmann · 2025-11-27T13:16:32Z

I think we should tackle this in a separate PR though

Of course.

c1888bb will be released in time for PHPUnit 12.5 which uses this for sebastianbergmann/phpunit@023845a.

staabm · 2025-12-06T07:31:09Z

progress on this PR is blocked on a new theseer/tokenizer release, which is blocked on a new phpunit 10.x release with fixed prefixing

sebastianbergmann · 2025-12-06T08:11:34Z

blocked on a new phpunit 10.x release with fixed prefixing

PHPUnit 10.5.60 has been released.

staabm · 2025-12-06T08:28:11Z

thank you!

codecov · 2025-12-06T08:37:17Z

Codecov Report

❌ Patch coverage is 98.87640% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.42%. Comparing base (bca180c) to head (8b04878).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/Report/Xml/Facade.php	97.67%	1 Missing ⚠️
src/Report/Xml/Report.php	94.44%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1125      +/-   ##
============================================
- Coverage     88.70%   88.42%   -0.29%     
+ Complexity     1391     1390       -1     
============================================
  Files           105      105              
  Lines          4782     4700      -82     
============================================
- Hits           4242     4156      -86     
- Misses          540      544       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

to speedup xml report generation

staabm · 2025-12-06T10:29:30Z

running xml-report generation on the sebastianbergmann/php-code-coverage codebase:

before this PR:

➜  php-code-coverage git:(main) ✗ XDEBUG_MODE=coverage vendor/bin/phpunit --coverage-xml tmp/coverage 
PHPUnit 12.5.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.28 with Xdebug 3.5.0
Configuration: /Users/staabm/workspace/php-code-coverage/phpunit.xml

......................................SSSSS....................  63 / 226 ( 27%)
..I............................................................ 126 / 226 ( 55%)
............................................................... 189 / 226 ( 83%)
.....................................                           226 / 226 (100%)

Time: 00:00.608, Memory: 30.00 MB

OK, but there were issues!
Tests: 226, Assertions: 645, Skipped: 5, Incomplete: 1.

Generating code coverage report in PHPUnit XML format ... done [00:00.295]

after this PR:

➜  php-code-coverage git:(dom3) ✗ XDEBUG_MODE=coverage vendor/bin/phpunit --coverage-xml tmp/coverage                                   
PHPUnit 12.5.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.28 with Xdebug 3.5.0
Configuration: /Users/staabm/workspace/php-code-coverage/phpunit.xml

......................................SSSSS....................  63 / 226 ( 27%)
..I............................................................ 126 / 226 ( 55%)
............................................................... 189 / 226 ( 83%)
.....................................                           226 / 226 (100%)

Time: 00:00.605, Memory: 30.00 MB

OK, but there were issues!
Tests: 226, Assertions: 645, Skipped: 5, Incomplete: 1.

Generating code coverage report in PHPUnit XML format ... done [00:00.209]

note

+ Generating code coverage report in PHPUnit XML format ... done [00:00.209]
- Generating code coverage report in PHPUnit XML format ... done [00:00.295]

sebastianbergmann · 2025-12-06T12:27:01Z

tests/_files/Report/XML/CoverageForBankAccount/BankAccount.php.xml

      </line>
    </coverage>
-    <source>
+    <source xmlns="https://schema.phpunit.de/coverage/1.0">


@staabm @theseer Are these changes intentional?

I think its not a change from a semantic point of view.

before this PR we imported one document into another which lead to the involved php extensions normalizing this namespace away. technically it is not necessary because its the same namespace as in the root phpunit element, but as this normalization no longer happens this xmlns="https://schema.phpunit.de/coverage/1.0" is showing up now.

staabm · 2025-12-06T12:43:17Z

...t/XML/CoverageForClassWithAnonymousFunction/source_with_class_and_anonymous_function.php.xml

        <token name="T_WHITESPACE"> </token>
        <token name="T_OPEN_BRACKET">(</token>
-        <token name="T_AMPERSAND_FOLLOWED_BY_VAR_OR_VARARG">&amp;</token>
+        <token name="T_AMPERSAND">&amp;</token>


I am not sure why this change happens though

diving into it more.. T_AMPERSAND was a token type in PHP4.x and it only existed in theseer/tokenizer, because it was hard-coded in https://github.com/theseer/tokenizer/blob/d1dd771235a40694cb5cb7239e531cf9b9702682/src/Tokenizer.php#L35

since PHP5+ the builtin token names are
T_AMPERSAND_FOLLOWED_BY_VAR_OR_VARARG
and/or T_AMPERSAND_NOT_FOLLOWED_BY_VAR_OR_VARARG

https://3v4l.org/tU46U#veol

opened a upstream discussion: theseer/tokenizer#44

staabm force-pushed the dom3 branch from f4d30f7 to c9a346b Compare November 22, 2025 08:32

This was referenced Nov 22, 2025

Add XMLSerializer->appendToWriter() theseer/tokenizer#38

Merged

PoC XML report rework infection/infection#2543

Draft

slow coverage data generation paratestphp/paratest#1044

Closed

staabm force-pushed the dom3 branch 2 times, most recently from c9a346b to b5a8841 Compare November 22, 2025 10:37

staabm force-pushed the dom3 branch from b5a8841 to 4b96d8e Compare November 27, 2025 07:09

staabm changed the title ~~Drop DOM dependency~~ Drop DOM dependency in XML Report Nov 27, 2025

sebastianbergmann mentioned this pull request Nov 27, 2025

Make <source> element in XML code coverage report optional sebastianbergmann/phpunit#6422

Closed

staabm force-pushed the dom3 branch from 4b96d8e to cca8e36 Compare December 6, 2025 08:27

staabm force-pushed the dom3 branch 2 times, most recently from 49fd2ac to ae31bc1 Compare December 6, 2025 08:36

staabm force-pushed the dom3 branch from ae31bc1 to 43e87fd Compare December 6, 2025 08:38

Drop DOM dependency in XML Report

8b04878

to speedup xml report generation

staabm force-pushed the dom3 branch from 43e87fd to 8b04878 Compare December 6, 2025 10:27

staabm marked this pull request as ready for review December 6, 2025 10:28

staabm referenced this pull request in theseer/tokenizer Dec 6, 2025

Update changelog

d1dd771

sebastianbergmann mentioned this pull request Dec 6, 2025

theseer/tokenizer version 2 is out #1128

Closed

sebastianbergmann reviewed Dec 6, 2025

View reviewed changes

staabm commented Dec 6, 2025

View reviewed changes

sebastianbergmann merged commit 5b74f62 into sebastianbergmann:main Dec 8, 2025
20 checks passed

staabm deleted the dom3 branch December 8, 2025 07:05

This was referenced Dec 8, 2025

T_AMPERSAND token theseer/tokenizer#44

Closed

Fix regression from update to theseer/tokenizer 2.x #1129

Merged

Uh oh!

Conversation

staabm commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staabm commented Nov 22, 2025

Uh oh!

sebastianbergmann commented Nov 26, 2025

Uh oh!

staabm commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebastianbergmann commented Nov 27, 2025

Uh oh!

staabm commented Dec 6, 2025

Uh oh!

sebastianbergmann commented Dec 6, 2025

Uh oh!

staabm commented Dec 6, 2025

Uh oh!

codecov bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

staabm commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebastianbergmann Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

staabm Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

staabm Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

staabm Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staabm Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

staabm commented Nov 22, 2025 •

edited

Loading

staabm commented Nov 27, 2025 •

edited

Loading

codecov bot commented Dec 6, 2025 •

edited

Loading

staabm commented Dec 6, 2025 •

edited

Loading

staabm Dec 8, 2025 •

edited

Loading