Remove getElementsByTagNameNS() for cases which can never find a element#1119
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom Nov 20, 2025
Merged
Remove getElementsByTagNameNS() for cases which can never find a element#1119sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom
sebastianbergmann merged 1 commit intosebastianbergmann:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
============================================
- Coverage 88.63% 88.61% -0.03%
+ Complexity 1398 1396 -2
============================================
Files 105 105
Lines 4795 4785 -10
============================================
- Hits 4250 4240 -10
Misses 545 545 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
staabm
commented
Nov 20, 2025
|
|
||
| public function tests(): Tests | ||
| { | ||
| $testsNode = $this->contextNode()->getElementsByTagNameNS( |
Contributor
Author
There was a problem hiding this comment.
we call this method on a document, which at this point of time cannot already contain a <tests> element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.