Skip to content

Represent CoverageData in objects#1105

Merged
sebastianbergmann merged 23 commits intosebastianbergmann:mainfrom
staabm:obj
Nov 20, 2025
Merged

Represent CoverageData in objects#1105
sebastianbergmann merged 23 commits intosebastianbergmann:mainfrom
staabm:obj

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Nov 8, 2025 •
edited
Loading

thesis is, that we need less memory when processing big projects

in phpstan-src I can see the coverage producing test-runs to consume ~3GB of data.
my gut feeling is, that if we would consume less data we would automatically get faster, because we need less memory allocations

running phpstan-src@8f9490ecc6

before this PR (37047b5):

➜  phpstan-src git:(2.1.x) ✗ XDEBUG_MODE=coverage php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Type/Constant --path-coverage
PHPUnit 12.4.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with Xdebug 3.4.7
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml

...............................................................  63 / 128 ( 49%)
............................................................... 126 / 128 ( 98%)
..                                                              128 / 128 (100%)

Time: 01:18.247, Memory: 1.18 GB

OK (128 tests, 209 assertions)

Generating code coverage report in PHPUnit XML format ... done [00:05.877]

with this PR (1b73b3c)

➜  phpstan-src git:(2.1.x) ✗ XDEBUG_MODE=coverage php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Type/Constant --path-coverage
PHPUnit 12.4.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with Xdebug 3.4.7
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml

...............................................................  63 / 128 ( 49%)
............................................................... 126 / 128 ( 98%)
..                                                              128 / 128 (100%)

Time: 00:53.183, Memory: 1.18 GB

OK (128 tests, 209 assertions)

Generating code coverage report in PHPUnit XML format ... done [00:05.709]

@staabm staabm force-pushed the obj branch 2 times, most recently from fc584c4 to 466072b Compare November 9, 2025 07:17
@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Nov 9, 2025

Is the only reason you're still considering this a draft/proof of concept because the tests need updating?

@staabm
Copy link
Contributor Author

staabm commented Nov 9, 2025

draft/proof of concept because the tests need updating?

yes

@staabm staabm changed the title POC: Represent CoverageData in objects Represent CoverageData in objects Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.70588% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.59%. Comparing base (45dff46) to head (9586250).
⚠️ Report is 25 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Node/File.php 60.00% 8 Missing ⚠️
src/Report/Html/Renderer/File.php 78.26% 5 Missing ⚠️
src/Data/ProcessedFunctionCoverageData.php 97.29% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1105      +/-   ##
============================================
+ Coverage     88.41%   88.59%   +0.18%     
- Complexity     1387     1404      +17     
============================================
  Files           102      105       +3     
  Lines          4712     4780      +68     
============================================
+ Hits           4166     4235      +69     
+ Misses          546      545       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@staabm staabm marked this pull request as ready for review November 9, 2025 17:17
@staabm staabm marked this pull request as draft November 9, 2025 17:28
@staabm
Copy link
Contributor Author

staabm commented Nov 9, 2025

tested a different case on the phpstan-src codebase:

running phpstan-src@8f9490ecc6

before this PR (37047b5):

➜  phpstan-src git:(2.1.x) ✗ XDEBUG_MODE=coverage php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Reflection/Annotations --path-coverage
PHPUnit 12.4.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with Xdebug 3.4.7
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml

......................................S^[[C..S...............         57 / 57 (100%)

Time: 06:09.856, Memory: 1.23 GB

OK, but some tests were skipped!
Tests: 57, Assertions: 1985, Skipped: 2.

Generating code coverage report in PHPUnit XML format ... done [00:05.955]

with this PR (3e53a48)

➜  phpstan-src git:(2.1.x) ✗ XDEBUG_MODE=coverage php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Reflection/Annotations --path-coverage
PHPUnit 12.4.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with Xdebug 3.4.7
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml

......................................S..S...............         57 / 57 (100%)

Time: 03:58.814, Memory: 1.31 GB

OK, but some tests were skipped!
Tests: 57, Assertions: 1985, Skipped: 2.

Generating code coverage report in PHPUnit XML format ... done [00:05.869]

@staabm staabm marked this pull request as ready for review November 9, 2025 18:13
@staabm
Copy link
Contributor Author

staabm commented Nov 9, 2025

After a few more tests, I think the optimization is only substantial when phpunit is invoked with --path-coverage

@staabm
Copy link
Contributor Author

staabm commented Nov 9, 2025

I think we can achieve similar things for regular line-coverage.. will prepare a separate PR

@staabm staabm mentioned this pull request Nov 10, 2025
Merged
@staabm staabm marked this pull request as draft November 10, 2025 08:56
@staabm staabm marked this pull request as ready for review November 10, 2025 10:27
sebastianbergmann
sebastianbergmann reviewed Nov 20, 2025
View reviewed changes
@sebastianbergmann sebastianbergmann merged commit d8bf935 into sebastianbergmann:main Nov 20, 2025
16 checks passed
@staabm staabm deleted the obj branch November 20, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastianbergmann sebastianbergmann sebastianbergmann left review comments

Assignees

No one assigned

Labels

type/performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @sebastianbergmann